[josm-dev] [PATCH 04/26] make Commands able to fail

[Alexander Wright]

On Tuesday 29 April 2008 14:28:08 Frederik Ramm wrote:
> Hi,
>
> > DESC
> > Make SequenceCommand able to do rollbacks
> > EDESC
> > If one command in a sequence fails, we can roll back all the
> > previously successful ones.
>
> Why would a command ever fail?
>
> In understanding, a command can only fail if there's a programming
> error in JOSM. Even so it is, of course, a good thing to handle that
> gracefully rather than just throw an exception. - But are your
> patches introducing commands that may fail for other reasons than
> programming errors?

As a JOSM user, I can say that it would be much nicer if JOSM could handle 
errors gracefully, rather than crash, potentially taking hours of work I'd 
forgotten to back up with it.

As JOSM gets more complicated, and especially when used with plugins, it 
becomes much harder to test every combination of commands and plugins. A 
fault tolerant base would definitely be a feature.

Cheers for all the hard work!

Alex.