[josm-dev] JOSM Ticket #263, cancelling an upload

[Dirk Stöcker]

On Sun, 10 Aug 2008, Florian Heer wrote:

> Index: org/openstreetmap/josm/io/OsmConnection.java
> ===================================================================
> --- org/openstreetmap/josm/io/OsmConnection.java        (revision 761)
> +++ org/openstreetmap/josm/io/OsmConnection.java        (working copy)
> @@ -127,8 +127,11 @@
>                Main.pleaseWaitDlg.currentAction.setText(tr("Aborting..."));
>                cancel = true;
>                if (activeConnection != null) {
> -                       activeConnection.setConnectTimeout(1);
> -                       activeConnection.setReadTimeout(1);
> +                       activeConnection.setConnectTimeout(100);
> +                       activeConnection.setReadTimeout(100);

1 and a half minute is much to much for an cancel. Acceptable is anything 
in a range 1 to 5 seconds I think. If you add such a long delay, then a 
notification is necessary telling the user what is done - like "Server 
response is missing. Waiting not more than 60 seconds before finally 
cancelling".

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)