[josm-dev] Difference between JOSM and JOSM-NG

Dirk Stöcker openstreetmap at dstoecker.de
Mon Aug 11 16:26:37 BST 2008


On Mon, 11 Aug 2008, c.malolepszy at gmx.de wrote:

> the main benefit of encapsulation is to make code more flexible
> for refactoring, internal changes, performance optimization
> through implementation hiding

That is true for new developments. For existing code other rules apply. 
The main rule here is: Changes should improve the software. Changes for 
the main benefit of cleaner style will be rejected. This is based on the 
fact that every change has side effects and very likely introduces new 
bugs.

And please do not assume that encapsulation is always good. It also has 
negative effects and the right balance is important.

> in case of modular software like josm with plugins is
> encapsulation a must for development and has not only something to do
> with clean style of code

Nothing is a must. As you see it works fine also without.

> refactoring and cleanups in an early phase of project are not
> so expensive and time-consuming like in a big grown old project.
> sometime it is to late to make big changes...

It is never to late. This is always possible.

BTW: Your shift and return keys are defective.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)




More information about the josm-dev mailing list