[josm-dev] Validator

[Dirk Stöcker]

On Sat, 16 Aug 2008, Dermot McNally wrote:

> Basically, the config file as it currently stands knows that nodes
> tagged with highway types are bad and it knows that certain classes of
> highway way that lack a ref attribute _may_ be bad. The drawback of
> the current validator as implemented is that only the message "Illegal
> tag/value combinations" is given. So in my case, before I read the
> config file, I looked at a highway tagged only "highway=tertiary" and
> had no way of knowing that the actual message is that a ref was
> missing.

This information is shown in the ToolTip. You get this when waiting a 
short time over the error message.

> The validator would in the event of catching such a case, add a
> validation violation of severity "info" with the text "Highway without
> a reference" instead of "Illegal tag/value combinations"
>
> What do you think? My fear is that if a change of this sort isn't
> made, once this currently small ruleset grows to 20 times its current
> size, we'll all have lots of validator violations but not know what
> we're doing wrong.

Actually this is already implemented. It's only moved to the ToolTip for 
two reasons:

a) There is so little space there in the Validator window
b) When I change the generic error message, the valdition dialog will be 
filled with lots of different message types. This makes finding certain 
types more difficult.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)