[josm-dev] [patch] Build process: Ant does not find svn executable

[Dirk Stöcker]

On Mon, 15 Dec 2008, Frederik Ramm wrote:

Quoting both of you:

> Stephan wrote:
>> Why not? What is the benefit of not submitting the patch? That
>> discussion should have been done weeks ago as I originally created the
>> ticket. Now I already invested time into fixing the problem.

Yes. And sometimes the solution is not good enough. That happens. Sorry 
for that.

>> Consider you have revision 1136, do some changes. In the meantime
>> another one changes and submits 1137. Now you submit your change. So it
>> is based on SVN 1136 and that should be in the version string. 1138
>> would be wrong. even if that is the revision of your change, you don't
>> have the files updated from 1137.
>
> Granted, but 1136 is just as wrong - you will build something that
> claims to be 1136 but is not the same as what someone else would build
> from 1136.

That why it is called "1136 SVN". This means it is a 1136 based build. And 
that's exactly right.

>> What about extending the build process? We could simply add a task to
>> update the depot. Maybe a "dist-latest" target that depends on "update"?
>> svnant has the possibility to query for files with conflicts. That check
>> might be interesting after running an update.

Auto-Update during build process is a big no-no for several reasons.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)