[josm-dev] Tasks for all of you

[Dirk Stöcker]

On Sun, 28 Dec 2008, Russ Nelson wrote:

> Potential improvements:
>  o convert all invocations of OsmReader.parseDataSet() to
>    OsmReader.parseDataSetOsm() to gain access to getParseNotes().

When useful, do it, but be aware of potential problems with plugins when 
changing the interface :-). The drawback of our open plugin interface.

>  o Doing something more sensible with the output presentation if
>    there are too many warnings than can fit on the screen (or will it
>    switch to a scrollbox?)

Cut after a certain number of lines and add "..."?

>  o It's possible that DataSet ought to be the entity that has
>    parseNotes.  That would make for a simpler patch, but not
>    necessarily more correct.

I don't think this is a good idea. The DataSet remains during lifetime, 
but these notes are only related to import.

> +                         parseNotes += "Skipping a way because it includes a node that doesn't exist: " + id + "\n";

This must be
parseNotes += tr("Skipping a way because it includes a node that doesn't exist: {0}\n", id);

Never construct string or use them without tr() or there is no 
translation.

Do you provide an updated patch?

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)