[josm-dev] Patch: fixes for delete

[David Earl]

On 17/12/2007 18:48, Frederik Ramm wrote:
> Hi,
> 
>>> This fails to compile in java 5.
>> And changing to java 6 doesn't happen before Apple does it?
> 
> No, it doesn't happen before Debian does it. 
> 
> Please, I've said that before, do not make changes that break the Java
> 5 build. I think if you have eclipse you can easily set it to Java 5
> compliance on a per-project basis.
> 
> The machine running the nightly JOSM build is a Debian Etch system. If
> there's reason to believe that the majority of people trying to build
> JOSM are doing so with Java 6, and fail, then we might make the move
> but currently I think Java 5 is still used by more people.
> 
> I'm quite angry with whoever is responsible for this to give us the
> alternative of either having code that works with Java 5 or code that
> works with Java 6 but not both. But I guess it was somehow necessary
> in the grand scheme of things. - Is there no #ifdef JAVA5 or so? Do we
> now need a "Java 6 branch"?

It's a nuisance, but since you can chose which to compile against, isn't 
it only a problem if someone makes a mistake (as above) or doesn't know 
you need to use 5, or if you want to use some feature of Java that is 
newly added to version 6?

David