[josm-dev] JOSM rendering improvements the last days - I'm guilty!

[Dirk Stöcker]

Hello,

> Most of these changes are based on the tagwatch output - BTW: thanks
> for this great tool from my side!

You know http://tagwatch.stoecker.eu/ ? I was very hard-working to set 
that up.

> But the most remarkable change I've done is to add some rules for
> stuff that *shouldn't* be used IMHO.
>
> Most notably, tags intended for ways not to be used on nodes:
>
> - lot's of highways (e.g. highway=motorway doesn't make a lot of sense
> on a node)
> - lot's of waterways
> - lot's of railways
> - oneway (makes *no* sense on a node)
>
> There are other stuff like oneway=no that also doesn't make a lot of
> sense as this is already the default. Also some stuff that was used
> times ago but there are better ways to tag them now (e.g.
> highway=viaduct vs. bridge=viaduct) are marked.

Some notes:

a) Would it be useful to add a new key to condition?

You now do 3 times (yes, true, 1)
        <condition k="oneway" v="yes"/>

I would suggest a
        <condition k="oneway" b="yes"/>
where b (boolean) catches all boolean values.

Helpful? If yes, I would implement it.

b) For the illegal tags you check: Could you make a list? I want to set up 
the tag checker validator with a pretty easy list like this:

node: highway  = *
*:    bridge   = no
way:  railway  = level_crossing

General idea: "type:tag=value" of wrong elements

(Better suggestions welcome :-)

Maybe also using regular expressions like
node: /.*way/ = *        /* (sorry have no better idea :-) */

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)