[josm-dev] Audio bug fixes and small changes

[David Earl]

I (hope I) have fixed the following bugs in the audio mapping:

1. Rubber band rectangles sometimes appeared when dragging the play head 
arrow(*).

2. When dropping the play head arrow on the track it didn't take any 
calibration into account, so could start playing a little way from where 
you dropped it (it was still accurate, the arrow just ended up a little 
way from where you dropped it).

And some enhancements (partly based on Chris Morley's experience using it):

3. When dropping the play head somewhere, the point on the track it 
selects is now the projection of the drop point onto the track rather 
than the nearest track point. For reasonably dense tracks this isn't 
important in itself, but it does mean if you went down a street both 
ways, you won't snap to the wrong side of the street because a track 
point on that side happened to be nearer than one on the side you 
dropped. This also applies to shift+drag for synchronization, which also 
improves synchronization accuracy in the absence of an explicit waypoint.

4. It seems at least some Garmin devices don't time stamp waypoints 
(Chris's doesn't at all except as a comment; mine puts only the date, as 
if it were midnight!). So you can now choose to include these waypoints 
as audio markers with their timing estimated from their position in 
relation to the track (projection as above). They have to be on or close 
to it (some devices let you make waypoints unrelated to the track).

5. Related to that, you can now use any combination of the methods for 
creating audio markers, not just the first one that works. The audio 
preferences have been reorganised to reflect this, though your previous 
settings should still work, where relevant.

David

(* I turned rubber banding off when the button is pressed on the play 
head, but it seems Java has already queued the same mouse down event for 
select mode before I can turn it off, so selection immediately turned it 
back on again. Hmph. Zoom mode was OK, which is why I hadn't seen this 
happening).