[josm-dev] [PATCH 09/24] AddNodeToWayCommand

[Frederik Ramm]

Hi Dave,

   one thing I don't understand about this "AddNodeToWayCommand" is
this:

You make an effort to manually undo the operation here: 

> +	@Override public void undoCommand() {
> +		Node removed = way.removeNode(location);
> +		if (removed != node)
> +			Main.debug("removed wrong node");

But you seem to have stored the original version of the way anyway, so
why not stupidly revert to that instead of only using it to get the
original modified flag?

> +	    way.modified = this.getOrig(way).modified;

Bye
Frederik

-- 
Frederik Ramm  ##  eMail frederik at remote.org  ##  N49°00'09" E008°23'33"