[josm-dev] Still looking for patch review
eGore at gmx.de
eGore at gmx.de
Mon Sep 8 14:51:04 BST 2008
> > I'm still looking for someone to look at the patch I submitted to ticket
> > 682[1] to add proxy server configuration to JOSM. I really like to see
> > this patch included into JOSM so please let me know if anything is wrong
> > with it and what I could do to fix is.
>
> Sorry. I had a look at it, but forgot about it afterwards.
>
> If I read the stuff correctly, you add a new settings menu. Correct?
> Please don't do that. We already have to many of these. Add the settings
> in the same menu, where the OSM user password is entered. There is enough
> space left.
I did the same approach as every "settings backend" which encapsulates the settings within one class. But in JOSM the "settings backend" is decoupled from the presentation to the user. Therefore presentation is (as you suggest) on the same tab as the username+password fields.
Regards,
Christoph
--
Psssst! Schon das coole Video vom GMX MultiMessenger gesehen?
Der Eine für Alle: http://www.gmx.net/de/go/messenger03
More information about the josm-dev
mailing list