[josm-dev] Commit message not empty

[Teemu Koskinen]

On Wed, 22 Apr 2009 02:20:20 +0300, Frederik Ramm <frederik at remote.org>  
wrote:

> But honestly, what would you say from a user interface perspective;
> should we try and keep changesets open? What JOSM currently does is open
> changeset - upload - close, for each upoad action. Some people have a
> habit of uploading once every five minutes and they are perhaps annoyed
> to have to type in a comment each time (could be fixed by caching the
> old comment), but thinking about later analysis of changesets it might
> perhaps be desirable to add changes to an existing changeset.
>

I made a trac ticket couple of hours ago:  
http://josm.openstreetmap.de/ticket/2436

I have a habit of refining the geometry, and uploading often, so it would  
be nice to have the edits in one changeset.


> Maybe so:
>
> * user starts josm, edits
> * uploads => gets asked for description => changeset created
> * on next upload => JOSM makes GET request to see if changeset still
> open on server => if yes, offers dialog box with radio buttons:
>
> ( ) continue existing edit session
>      commit message: [whatever was last typed, editable]
>
> ( ) start new edit session
>      commit message: [             ]
>
> I see the possible problem of people always continuing the existing
> session even if they are now doing something completely different...
>

Yes, that might be a small problem, but I'd prefer the possibility for  
reusing the old changeset.

Here are few ideas to possibly alleviate the problem of unrelated data  
being added to the old changeset:

  - Some fuzzy logic to detect how far the new edits are from the  
changeset's bbox, and deciding the default based on that
  - If the osmlayer is deleted, then the changeset should close, if not  
automatically, then at least a dialog asking if it should be closed
  - The default action for the next upload should be set to new session  
when the user downloads more data (at least if it's outside of the current  
area of downloaded data)


> Bye
> Frederik
>


Teemu Koskinen