[josm-dev] Commit message not empty

[Richard Fairhurst]

Frederik Ramm wrote:
> The problem is that Potlatch has to open the changeset before the 
> user has done anything. And while I am a great fan of commit 
> comments, requesting that the user describe what he is about to 
> do, before he has even done it, would be going to far in my eyes! 

Well, in reality Potlatch can put any comment where the hell it likes
because it's not hidebound by the XML API that you poor saps have to labour
under...

Potlatch writes comments as part of the _close_ changeset option. But you
can't enforce it because there's no way to stop someone closing their
browser or, in extremis, turning off their computer.

You can, however, get ActionScript to talk to JavaScript, so that Potlatch
maintains a "comment needed" variable in JS. You can then add some JS so
that, when you try to close the window, a little "You haven't added a
comment - are you sure?" alert pops up. The main reason I haven't done this
yet is that AS-JS communication is fine in Firefox and Safari, but evil in
Internet Explorer. But, having figured out how to tame IE (I think)
yesterday, it might be along before too long.






Frankly, though, most of 0.6 is a solution designed by JOSM programmers for
JOSM internals and I think the rest of us have been subject to enough
heartbreak in trying to cope with it already. <grins evilly and runs away
very fast>

cheers
Richard
-- 
View this message in context: http://www.nabble.com/Commit-message-not-empty-tp23165136p23220852.html
Sent from the OpenStreetMap - JOSM Dev mailing list archive at Nabble.com.