[josm-dev] Relation member sort cleanup

[Dirk Stöcker]

On Thu, 9 Jul 2009, Christiaan Welvaart wrote:

> Since the patch I mentioned in my comment on 
> http://josm.openstreetmap.de/ticket/2789 was only a draft, now that it was 
> checked in with changeset 1748 it needs to be cleaned up a bit. The attached 
> patch contains the following:
> - relation member sort fixes:
>   o drop bogus compare-by-value TreeMap, use a HashMap instead
>   o remove diagnostic message for each sort step
>   o do not emit a message when the last element could not be 'sorted'

Please no patches in group. The Trac is better here, as I sometimes 
overlook patches in group and then they are forgotten.

> It was mentioned that the sort feature is not really useful. Why is that, and 
> how could it be made (more) useful?

I should have been more verbose. I did not deep-analyse the mechanism but 
it seems you only sort the first block of ways. This does not work for 
splintered relations.

In multipolygon drawing of mappaint I choosed to join all ways at there 
end points and the as a result I have multiple groups of joined ways. This 
can be done in relation sort as well. The last step would then be to 
bring these groups in correct order (i.e. sort them by minimal distance of 
end points.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)