[josm-dev] preparing a patch for #2483

[Dirk Stöcker]

On Thu, 4 Jun 2009, Dieter Muecke wrote:

> I've just created a patch to fix a problem in JOSM  and found lots of
> differences caused by eclipse source code formatter.
> Is it appreciated to send a patch including source code
> beautifications made by eclipse?

No. Do only included format changes, when they apply to the position, 
where you anyway changed stuff. Patches in Trac must be readable and 
formating changes will obscure the real changes.

> What is the next step in trac? Shall I reassign it to another person
> or mark it fixed?

Never mark it fixed. Fixed means "Fixed in SVN". Add a "[PATCH]" in the 
subject, so I see the patch when looking for it. And care for the comments 
you get :-)

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)