[josm-dev] Extrude 'move along normal' and cleanups

Robert Scott lists at humanleg.org.uk
Sun Nov 1 15:39:47 GMT 2009


On Sunday 01 November 2009, Dirk Stöcker wrote:
> What should this change mean?
> 
> -            return tr("Drag a way segment to make a rectangle.");
> +            return tr("");

The previous code used a 'mode' of null to represent the initial (non-dragging) state of the mapmode and an inconsistent use of the 'select' mode. I changed it so null is an invalid mode and 'select' is the initial mode. Hence at this this line I didn't know what to say when mode is null. Perhaps it should be some default extrude string - I don't know - but it should never happen.

> BTW: Best is to attach patches as Trac tickets.

Noted.


robert.




More information about the josm-dev mailing list