[josm-dev] visible vs. deleted

[Karl Guggisberg]

Hi Matthias

> I guess this happens when trying to delete a deleted object.  But why does
JOSM make a distinction between deleted 
> and visible when the API doesn't?
Because an object could be deleted in one layer but not in the other. When
you merge the first layer to the second you should end up with a conflict. 

"deleted==true" means:  "marked to be deleted on the server"
"visible==false" means: "successfully deleted on the server"

> What this comes down to is the question what JOSM should do when during
data update it finds that an object it has 
> marked for deletion is already deleted on the server.  I think it should
be safe to just remove those objects from the 
> dataset.  After all it is not really a conflict when the JOSM user and the
API both think that something should go away.
Agree. Currently, this case triggers a conflict in JOSM. We could change the
upload process to avoid that. 

Regards
Karl

-----Ursprüngliche Nachricht-----
Von: josm-dev-bounces at openstreetmap.org
[mailto:josm-dev-bounces at openstreetmap.org] Im Auftrag von Matthias Julius
Gesendet: Freitag, 25. September 2009 16:12
An: josm-dev at openstreetmap.org
Betreff: [josm-dev] visible vs. deleted

Hi all,

The API only has a visible flag to indicate deleted objects.  Yet, on
conflict JOSM is presenting this in the Resolve conflicts dialog:

  My version                  Their version   

  deleted                     not deleted
  visible (on the server)     not visible (on the server)


I have a hard time making sense of this.

I guess this happens when trying to delete a deleted object.  But why does
JOSM make a distinction between deleted and visible when the API doesn't?

What this comes down to is the question what JOSM should do when during data
update it finds that an object it has marked for deletion is already deleted
on the server.  I think it should be safe to just remove those objects from
the dataset.  After all it is not really a conflict when the JOSM user and
the API both think that something should go away.

Matthias

_______________________________________________
josm-dev mailing list
josm-dev at openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev