[josm-dev] svgSalamander source code modification

[cedric.olivier at free.fr]

Hi,

I have asked svgsalamander upstream to add this method.
It's now done in svgsalamnder upstream svn project.

For future, could you try to ask modification to upstream before applying patch to source code ?
For your information, they have done modification in one day.

Regards
Cédric OLIVIER (Cquad)

----- Mail original -----
De: "Upliner" <upliner at gmail.com>
À: "Paul Hartmann" <phaaurlt at googlemail.com>
Cc: josm-dev at openstreetmap.org
Envoyé: Lundi 7 Novembre 2011 10:00:42
Objet: Re: [josm-dev] svgSalamander source code modification

Argh... I knew that there may be some problems with patching
svgsalamander in the josm core. But the only acceptable workaround is
to return stripped-hacked version of svgsalamander into the importvec
plugin. I can't find a way to properly import some kind of SVGs
without possibility to get AffineTransform of the SVGElement.

On Sat, Nov 5, 2011 at 11:19 PM, Paul Hartmann <phaaurlt at googlemail.com> wrote:
> On 11/04/2011 06:59 AM, Olivier Cédric wrote:
>> Hello,
>>
>> I am Fedora packager of josm.
>> (https://admin.fedoraproject.org/updates/josm)
>>
>> I saw you have recently add some other project source code in svn.
>> According to Fedora policies, I must package all other project in other
>> package. So I have made another package for svgsalamander.
>> (https://admin.fedoraproject.org/updates/svgsalamander)
>>
>> But with svn revision 4550, some source code modification has been
>> applied :
>>
>> +++ josm/src/com/kitfox/svg/TransformableElement.java
>> @@ -53,6 +54,11 @@
>>      {
>>          super(id, parent);
>>      }
>> +
>> +    public AffineTransform getXForm()
>> +    {
>> +        return xform;
>> +    }
>>  /*
>>      public void loaderStartElement(SVGLoaderHelper helper, Attributes
>> attrs, SVGElement parent)
>>      {
>>
>> It is a problem for me. If this new method is required, why don't ask
>> svgsalamander upstream project to add it ?
>>
>> Regards,
>> Cédric Olivier (cquad)
>
> Hi Cédric,
>
> I think it simply didn't occur to us so far. Go ahead and request
> inclusion in upstream! Isn't it possible to add the method for the
> svgsalamander Fedora package?
>
> Alternatively, you could provide a workaround, so we no longer need to
> patch the library. (E.g. it should be possible to override the access
> modifier using reflection.)
>
> Paul
>
> _______________________________________________
> josm-dev mailing list
> josm-dev at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
>



--
Best regards,
Upliner

_______________________________________________
josm-dev mailing list
josm-dev at openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev