[josm-dev] SideButton misusage

[Stefan Breunig]

As far as I understand SideButton is intended to be used with the right
hand dialogs, so the icons don’t take up that much space. Everything
that SideButton does is resize them to 20 pixels and offer some random
convenience features (however, in core all but FilterListDialog use the
new SideButton(Action) constructor).

I can see why we want smaller icons in the sidebar dialogs; but I don’t
see why we want them in the save or download dialog. Is there any reason
to this or is this simply a coding error?

If it’s a coding error, maybe it’s possible to assert that SideButtons
are only used in ToggleDialogs.

Furthermore, if we want 20px icons and 24px icons, we should either ship
them or switch to SVG. This will probably increase the size of josm.jar,
is this a problem?

--Stefan

PS: I hope this mail doesn’t appear twice, my address did change and I
was subscribed with the old one