[josm-dev] JOSM Version check source (VersionTest macro) to troubleshoot strange version

[Dirk Stöcker]

On Fri, 9 Oct 2015, Sebastiaan Couwenberg wrote:

>> No. As you mark it as Debian in the agent it's correct to strip the SVN
>> text. This patch as far as I remember was designed in cooperation with
>> me. For SVN we react different in tickets - We tell the user first to
>> update to recent SVN version assuming the user can build the software
>> himself. This is not the correct reply for Debian version, so the SVN
>> should not be there. Simply change the patch to set "Debian" instead of
>> "SVN", as I see that there is no patch in the GIT yet for this purpose.
>
> Based on the bug report and your changes to the VersionTest macro, it
> seemed the patch may have been unneeded in the first place.
>
> I prefer the User-Agent without SVN substring anyway, so I'll happily
> keep it for the Debian package.
>
> The Debian Build-Name change is currently only available in the
> 00-build.patch on the stretch branch:
>
> https://anonscm.debian.org/cgit/pkg-grass/josm.git/tree/debian/patches/00-build.patch?h=stretch#n57

Hmm, maybe these two together need some rework. If you simply change 
Is-Local-Build (above the Build-Name) to false the patch to Version.java 
can be dropped and manifest is more correct.

Removing SVN from the other line in build.xml is probably still required 
(we don't use build.xml but a makefile on the server). But I'd include 
that single change in your 00-build.patch for better readability.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)