[Merkaartor] Assorted bugs

[Arnd Baecker]

Hi Timo,

thanks a lot for your work on the geotagged images -
it is very much appreciated!!

On Tue, 3 Mar 2009, [ISO-8859-1] Timo Schlüßler wrote:

> Having an extra layer for images will raise some new problems: when
> loading images according to their timestamps, they will be added to
> existing nodes and so it will happen that there are two nodes at the
> same place, one in the new image layer and one in the track layer.
> originally the layer selection was meant to say which timestamps should
> be compared to the image file timestamps to find out where the image was
> taken.
> it would be a nice idea to have an extra imagelayer for images
> containing position data in their exif-headers, but I (at least) think
> not really for images without these informations.

Ah, I see - I just had the case in mind, that
all the images are already geotagged.

> If I can find some time I will (try to) add a feature to select the
> next/previous trackpoint containing an image.

Works very nice! Thanks a lot.
There is only the issue, that the ordering according
to time is not respected.
I debugged this a little bit, and it was a combination of
two small issues, which seem to work fine with the
attached patch, which just changes two lines in GeoImageDock.cpp:

-                       if (latS.isEmpty() || lonS.isEmpty()) {
+                       if (!latS.isEmpty() && !lonS.isEmpty()) {
and
-                       usedTrackPoints << TrackPointData(Pt->id(), file, QFileInfo(file).created(), it == end);
+                       usedTrackPoints << TrackPointData(Pt->id(), file, time, it == end);

Best, Arnd


> regards, timo
>
> Arnd Baecker wrote:
> > Hi,
> >
> > I have just managed to get the support for
> > geolocalized images working
> > (via: `qmake GEOIMAGE=1    Merkaartor.pro`)
> > and also came across a few related things:
> >
> > On Mon, 2 Mar 2009, Yves Goergen wrote:
> >
> > [...]
> >
> >
> >> Readonly layers are asked to be made writeable when loading geotagged
> >> images to them (rev 13943): This is not acceptable actually, sorry. I'm
> >> glad we now have read-only layers and track layers are read-only by
> >> default (at option), but when I want to load my photos into it, I need
> >> to make it writeable again. Why that? Can't the photos be added to a
> >> read-only layer? Or at least can't the layer be made read-only again
> >> after loading the photos? And could that new warning message please go
> >> away then?
> >>
> >
> > What about just adding a new layer (eg. named "GeoImages" etc.)
> > when loading geotagged images?
> >
> > Somehow related to the previous point:
> > It would be nice, if the images could be specified on the commandline, eg.
> >   merkaartor *.gpx *.jpg
> > Currently, one gets the error message:
> > "No suitable layer found. Please first download data from OSM server
> > or open a track".
> >
> > Actually, I don't think that this should be really necessary at all:
> > namely, even just loading images should be allowed
> > so that one then could download a corresponding region.
> >
> > One more question:
> > Is there a way to go from one image to the next image
> > by some keyboard short-cut (eg. PageDown/PageUp, maybe with
> > some modifier, for next/previous image)?
> > (Images should be ordered according to time).
> >
> > Thanks a lot, Arnd
> >
> > _______________________________________________
> > Merkaartor mailing list
> > Merkaartor at openstreetmap.org
> > http://lists.openstreetmap.org/listinfo/merkaartor
> >
> >
> >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: geoimagedock.diff
Type: text/x-diff
Size: 1041 bytes
Desc: 
URL: <http://lists.openstreetmap.org/pipermail/merkaartor/attachments/20090304/7980cced/attachment.diff>