[Merkaartor] Merkaartor fails to escape from bash

[Daniel van Gerpen]

Hi list,

compiling current svn on linux (ubuntu 9.10, /bin/sh links to bash)
fails because of this define on the cmdline

  -DREVISION=-svn(19041)

which gcc does not understand. This can be fixed by changing src/Config.pri
to contain

  REVISION="\'-svn(19041)\'"

While this "works on my machine" [TM], does it possibly break in other
shells / on other platforms? And yes, I'm looking at you, cmd.exe.

Regards,
Daniel

----

$ qmake-qt4 
$ make
cd src/ && /usr/bin/qmake-qt4 src.pro -unix -o Makefile
cd src/ && make -f Makefile 
make[1]: Entering directory `/home/dvg/workspaces/mirrorMerkaartor/src'
/usr/bin/uic-qt4 Docks/DirtyDock.ui -o ui_DirtyDock.h
/usr/bin/uic-qt4 Docks/StyleDock.ui -o ui_StyleDock.h
/usr/bin/uic-qt4 Docks/MinimumRelationProperties.ui -o ui_MinimumRelationProperties.h
/usr/bin/uic-qt4 Docks/MinimumTrackPointProperties.ui -o ui_MinimumTrackPointProperties.h
/usr/bin/uic-qt4 Docks/MinimumRoadProperties.ui -o ui_MinimumRoadProperties.h
/usr/bin/uic-qt4 Docks/FeaturesDock.ui -o ui_FeaturesDock.h
/usr/bin/uic-qt4 AboutDialog.ui -o ui_AboutDialog.h
/usr/bin/uic-qt4 DownloadMapDialog.ui -o ui_DownloadMapDialog.h
/usr/bin/uic-qt4 MainWindow.ui -o ui_MainWindow.h
/usr/bin/uic-qt4 Sync/SyncListDialog.ui -o ui_SyncListDialog.h
/usr/bin/uic-qt4 UploadMapDialog.ui -o ui_UploadMapDialog.h
/usr/bin/uic-qt4 GotoDialog.ui -o ui_GotoDialog.h
/usr/bin/uic-qt4 MultiProperties.ui -o ui_MultiProperties.h
/usr/bin/uic-qt4 Interaction/CreateDoubleWayDock.ui -o ui_CreateDoubleWayDock.h
/usr/bin/uic-qt4 Interaction/CreateRoundaboutDock.ui -o ui_CreateRoundaboutDock.h
/usr/bin/uic-qt4 PaintStyle/PaintStyleEditor.ui -o ui_PaintStyleEditor.h
/usr/bin/uic-qt4 Preferences/PreferencesDialog.ui -o ui_PreferencesDialog.h
Warning: name label_24 is already used
Warning: name horizontalLayout_7 is already used
Warning: name label_25 is already used
/usr/bin/uic-qt4 Preferences/WMSPreferencesDialog.ui -o ui_WMSPreferencesDialog.h
/usr/bin/uic-qt4 Preferences/TMSPreferencesDialog.ui -o ui_TMSPreferencesDialog.h
/usr/bin/uic-qt4 Utils/PictureViewerDialog.ui -o ui_PictureViewerDialog.h
/usr/bin/uic-qt4 Utils/SelectionDialog.ui -o ui_SelectionDialog.h
/usr/bin/uic-qt4 ExportDialog.ui -o ui_ExportDialog.h
/usr/bin/uic-qt4 Render/NativeRenderDialog.ui -o ui_NativeRenderDialog.h
/usr/bin/uic-qt4 GPS/qgpsmainwindowui.ui -o ui_qgpsmainwindowui.h
/usr/bin/uic-qt4 Tools/WorldOsbManager.ui -o ui_WorldOsbManager.h
'' isn't a valid widget
/usr/bin/uic-qt4 NameFinder/namefinderwidget.ui -o ui_namefinderwidget.h
g++ -c -pipe -g -Wall -W -D_REENTRANT -DVERSION=0.15 -DREVISION=-svn(19041) -DUSE_WEBKIT -D_TTY_POSIX_ -DUSE_GPS -DPLUGINS_DIR=/usr/local/lib/merkaartor/plugins -DSHARE_DIR=/usr/local/share/merkaartor -DTRANSDIR_MERKAARTOR=/usr/local/share/merkaartor/translations -DWORLD_SHP=/usr/local/share/merkaartor/world_background.osb -DQT_WEBKIT_LIB -DQT_SVG_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I../include -I../interfaces -I. -IRender -Iqextserialport -IGPS -INameFinder -IDocks -ITools -ITagTemplate -I. -I. -o browserimagemanager.o QMapControl/browserimagemanager.cpp
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `g++ -c -pipe -g -Wall -W -D_REENTRANT -DVERSION=0.15 -DREVISION=-svn(19041) -DUSE_WEBKIT -D_TTY_POSIX_ -DUSE_GPS -DPLUGINS_DIR=/usr/local/lib/merkaartor/plugins -DSHARE_DIR=/usr/local/share/merkaartor -DTRANSDIR_MERKAARTOR=/usr/local/share/merkaartor/translations -DWORLD_SHP=/usr/local/share/merkaartor/world_background.osb -DQT_WEBKIT_LIB -DQT_SVG_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I../include -I../interfaces -I. -IRender -Iqextserialport -IGPS -INameFinder -IDocks -ITools -ITagTemplate -I. -I. -o browserimagemanager.o QMapControl/browserimagemanager.cpp'
make[1]: *** [browserimagemanager.o] Error 2
make[1]: Leaving directory `/home/dvg/workspaces/mirrorMerkaartor/src'
make: *** [sub-src-make_default] Error 2