[osmosis-dev] TagFilter

[Andrew Byrd]

On 03 Dec 2009, at 12:35, Brett Henderson wrote:
>
> Hi Andrew,
>
> I've just tried to apply the patch but ran into a few problems.
> * Can you please run "ant checkstyle" and fix any errors that pop  
> up?  These errors are currently breaking the build.  Most are code  
> formatting issues and should be fairly easy to fix.  You can  
> configure eclipse to highlight checkstyle issues if you install the  
> checkstyle eclipse plugin.
> * There is a compilation warning.  At least there is in Eclipse.   
> There is a "private Class filterClass" variable in TagFilter that  
> has a warning because Class is a generic type and no type is  
> specified.  You can fix it with something like "private Class<?  
> extends EntityContainer> filterClass".
> * Code should never write to System.out or System.err.  System.out  
> in particular is bad because it corrupts data if piping data between  
> apps.  The debug statements you referred to can be kept but change  
> them to use JDK Logging.  You can use a class like  
> PostgreSqlDatasetTruncator as an example.  The type of logging  
> you're writing out would probably be suitable for a "finer" level of  
> logging.
> * Do you have any unit tests?  Nothing too extravagant is required,  
> but a couple of simple tests would be very helpful.

OK, thanks for the pointers. I'll look into all of the above. I don't  
usually program in Java, so some of this (formatting/style issues) I'm  
picking up as I go along. Developing some tests should also reassure  
me that everything works as expected - I was a little wary of  
inorporating this into the repository without more testing.

-Andrew