[osmosis-dev] Tags class

[Brett Henderson]

If you mean the ones you submitted the patch for then I haven't 
committed them yet, they're still on the jpf branch.  I haven't 
forgotten and aren't ignoring them, I was just waiting until I had a bit 
more time to do it consistently across all entity types.  I should stop 
playing with other things and get it out of the way :-)

My main concern at the moment with creating a separate Tags class would 
be that it should also be done for WayNodes, RelationMembers, etc.  It's 
much simpler to just add the methods to the relevant Entity classes.  Is 
there a reason for creating a separate Tags class other than keeping the 
Entity classes themselves smaller (although that might be a good reason 
itself)?

Marcus Wolschon wrote:
> Didn't we just add such methods to Entity ?
>
> Marcus
>
> On Wed, Feb 4, 2009 at 5:06 PM, Jochen Topf <jochen at remote.org> wrote:
>   
>> Currently there is a Tag class and the list of tags in an Entity is
>> stored in a Collection<Tag>. Would it make sense to create a Tags class?
>> This class could then allow methods like getTagByKey() oder hasKey().
>>
>> For the moment the implementation maybe could just be a child class of
>> Collection<Tag>. The mentioned methods would just iterate over all tags
>> and do the checks. If we ever wanted to change to a hash based version
>> or so we can do that inside the class without bothering anybody outside.
>>
>> Jochen
>> --
>> Jochen Topf  jochen at remote.org  http://www.remote.org/jochen/  +49-721-388298
>>
>>
>> _______________________________________________
>> osmosis-dev mailing list
>> osmosis-dev at openstreetmap.org
>> http://lists.openstreetmap.org/listinfo/osmosis-dev
>>
>>     
>
> _______________________________________________
> osmosis-dev mailing list
> osmosis-dev at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/osmosis-dev
>