[osmosis-dev] duplication of nodes on apply-change

[Brett Henderson]

In an attempt to fix this I have done the following:
* Rolled back EntityByTypeThenIdComparator to the previous behaviour of only
checking type then id.
* Created a new EntityByTypeThenIdThenVersion comparator which (obviously
:-) includes version as part of the checking.
* Updated ChangeMerger (--merge-change) to use the new version inclusive
comparison.
* Updated SortedChangePipeValidator used by ChangeMerger (--merge-change)
and ChangeSimplifier (--simplify-change) to use the new version inclusive
comparison.
* Created a new --simplify-change task that reduces full history diffs to
delta diffs to allow old tasks relying on single changes per entity to
continue to work.

At some point I need to go through all change processing tasks and check to
see if they need updates to support full history diffs but I'm not sure when
I'll get around to it.

If anybody sees any problems with the changes I've made please let me know.

Brett

2009/11/18 Maxim Dubinin <sim at gis-lab.info>

> Thanks for explanation, Frederik.
> I confirm that it was indeed the problem and rolling back to rev18121
> fixed the issue. I also note that 0.31.3 still has this bug.
>
> Maxim
>
> Вы писали 16 ноября 2009 г., 15:11:06:
>
> FR> Hi,
>
> FR> Maxim Dubinin wrote:
> >> MD> But after I do:
> >> MD> osmosis --read-xml-change
> file="data/updates/20091112-20091113.osc.gz"
> >> MD> --read-xml file="data/rus.osm" --apply-change --write-xml
> file="data/rus-new.osm"
> >>
> >> MD> I'm getting two versions of the same node in the output:
>
> FR> Is it possible that I am resposible for this because I recently changed
> FR> the sorting function to treat something with version=x+1 as "larger
> FR> than" something with version=x, instead of "equal"?
>
> FR> (SVN r18230, change to EntityByTypeThenIdComparator...)
>
> FR> Bye
> FR> Frederik
>
>
> _______________________________________________
> osmosis-dev mailing list
> osmosis-dev at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/osmosis-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/osmosis-dev/attachments/20091123/f3628a53/attachment.html>