[osmosis-dev] Sorting (and test whining)

Frederik Ramm frederik at remote.org
Wed Oct 21 08:28:09 BST 2009


Hi,

    I have committed a change to trunk that, when dealing with 0.6 
files, also looks at the version of an object for comparison and sorting 
(not only type and id).

This was necessary in order to process replicate diffs which sometimes 
contain the same object twice, causing the old implementation to 
complain about change streams "not being sorted" (as "being sorted", for 
Osmosis, means that every object has to be greater than the previous).

If this causes problems for anybody then another option would have been 
to leave the sorting code unchanged and instead replace the "greater 
than" requirement in the sorted stream validator with a "greater or 
equal" requirement.

Bye
Frederik

PS: Can we remove those tests the failure of which can be safely 
ignored? So that someone who checks out and builds Osmosis has a chance 
to build it without tests failing, and only if you do "ant 
--with-all-bells-and-whistles-and-exotic-features" do you get the 
current "something always fails but don't bother" functionality?




More information about the osmosis-dev mailing list