[osmosis-dev] Patch: ReplicationLagReader

[Peter Körner]

Am 26.07.2010 13:05, schrieb Brett Henderson:
> I'm happy to apply it, just needs a few cleanups first.
>
>     * If you run "ant clean all" from the replication directory you'll
>       notice it fails at the checkstyle step (You may need to run "ant
>       publish" from the root directory first).  Some code formatting
>       needs to be cleaned up to fix the checkstyle errors.
>     * Kinda picky, but while you're fixing the checkstyle errors, might
>       be worth fixing some typos in the comments (locale->local,
>       beeing->being, etc).
>     * One comment states "If local state isn't available we need to copy
>       server state to be the initial local state then exit.".  That
>       comment has been copied from my code but it's not true for your
>       implementation.  That threw me off course when reading it for the
>       first time.
>     * The munin config files can't live in the source tree.  They
>       definitely won't be included in the final package if they're
>       there, they'll only get embedded inside the
>       osmosis-replication.jar file which isn't much help.  They'll need
>       to live in the "package" project somewhere.  There's already a
>       "script" directory which gets bundled with the release, would a
>       "munin" directory in there be appropriate?
I fixed all this and attached a new version of the patch. Thank you for 
reviewing it. If you still see typos I'm sorry about it - i don't have 
eclipse and thus no automatic spell checking - and I'm no native 
speaker, so sorry for them.

>     * And finally, once it's been committed you'll need to document it
>       on the 0.36 release wiki page
>       http://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage_0.36
>       including references to the munin files.
That shall not be the problem.

Peter
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: osmosis-rrl.patch
URL: <http://lists.openstreetmap.org/pipermail/osmosis-dev/attachments/20100726/b1a7695c/attachment.ksh>