[osmosis-dev] [PATCH] Allow user to set buffer sizes instead of hardcoding them in --merge and other tasks

[Brett Henderson]

Hi Igor,

On Fri, Jun 24, 2011 at 9:53 PM, Igor Podolskiy <
igor.podolskiy at vwi-stuttgart.de> wrote:

> Hi @osmosis-dev,
>
> during my recent work I noticed that --merge, --merge-change,
> --apply-change, --derive-change and --append-change use input buffers
> (DataPostbox) but don't allow me to set the buffer size, hardcoding it
> instead to very low values (10 or 20). I was able to achieve serious
> performance improvements for big data sets (up to 3x faster with
> apply-change) by modifying those tasks to accept an additional command line
> parameter and setting the input buffer size to something more appropriate
> for my hardware, like 10000.
>
> The attached patch contains my modifications. It's mostly trivial, as the
> input buffer size is already a parameter and I only needed to add argument
> handling in the task factory.
>
> This change is fully backwards compatible with respect to the behavior or
> the user interface of the tasks (I believe at least).
>
> Needless to say, if the patch gets applied, I volunteer to update the wiki
> pages :)
>

Do you have access to svn?  It seems like a good idea and I don't have any
issues with it.  Just check the Hudson build afterwards to make sure the
build still passes.

On that note, Hudson is currently broken due to the databases being dropped
during an upgrade.  I hope to have it up and running again in a few days.

Brett
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/osmosis-dev/attachments/20110704/1a47f6b7/attachment.html>