[osmosis-dev] [patch] Merge command an resulting bounding box?

[Dominik Röttsches]

Hi Igor,

I applied your patch (applies cleanly without problems) and ran the Osmosis compilation using ant publish. Then ran my previous maps through the new osmosis:

$ ./osmosis --rb finland.osm.pbf --rb germany.osm.pbf --rb us-west.osm.pbf --merge --merge --wb DE_FI_USW.osm.pbf omitmetadata=true

Next, I ran the generated merged map through splitter, which outputs a bounding box for the unified bounds, very nice. You can also see that all the split areas are now part of the map: 
http://maps.google.com/maps?q=http%3A%2F%2Froettsches.de%2Fdominik%2Fareas_defiusw.kml
(in contrast to previously, where only Finland was covered in the areas).

Splitter also creates much more tiles, which seems to work correctly now (instead of leaving out everything except Finland, as before). Currently running mkgmap, should be fine, though.

So, basically, I tested your patch sucessfully for the case:

> 2. If both sources have a bound, then a bound corresponding to the unions of bounds 0 and 1 is emitted to the merged stream.



> In case 3b - when a bound is "removed" -, there are three possibilities controlled by the new boundRemovedAction keyword argument:
> 
> * ignore: don't do anything and continue
> * warn: emit a warning to the log but continue (default)
> * fail: stop processing altogether

Thinking twice about this, I would perhaps consolidate that to default failure (with detailed explanations in the log how to overcome this problem, i.e. how to specify the following keyword argument) plus  a keyword argument "ignoreBounds" which would allow continuing (equivalent to your "* ignore" case). This would ensure that the user looks at the issue and ensures correct functioning or fixing the input maps. - just my suggestion. Maybe case 1 should be covered by this behavior, too - not sure.

In any case, thanks a lot for your great work - the whole thing works nicely for me now. 
If you have a bug report somewhere I can add the details of my partial verification.


Dominik