[osmosis-dev] Problem creating pbf data with osmosis 0.39

[Igor Podolskiy]

Hi Michael,

On 21.09.2011 00:04, Igor Podolskiy wrote:
> On 20.09.2011 22:50, Michael Prinzing wrote:
>> Now, there is an "empty" bounding box, and the timestamps are far in
>> the past (looks like an integer of -1 converted to a timestamp to me).
> [...]
> I could reproduce the empty bounding box problem, though, thanks for the
> report. IMHO this is a bug and unless someone who is more knowledgeable
> than me says it's a feature (Brett? Scott? :)), I'm going to try to fix it.
>
> I am sure it is somewhere between the PBF writer and the PBF reader
> (i.e. it is not an XML reader/writer problem), more precisely in the
> header block handling, but I need to investigate it a little further...
> means, it could take a couple of days before I come up with a fix.
okay, that was a bit simpler than it seemed yesterday. The HeaderBBox 
field is declared optional in the PBF definition, but the adapter code 
for Osmosis (OsmosisBinaryParser) didn't check whether the bounding box 
was set and was reading it anyway. The generated protobuf code doesn't 
prevent this, and the adapter was just reading the default values which 
happen to be zeroes.

I just fixed it in r26690 in the current trunk, so no more spurious 
<bounds> from the PBF reader.

Greetings from Stuttgart,
Igor