[OSRM-talk] adding way id and direction to output

Jens Thiele karme at karme.de
Tue Apr 30 08:44:09 UTC 2013


Emil Tin <emil at tin.dk> writes:

> I fixed these and added a few tests.

ok

similar place where i am not sure it is correct:
./GraphLoader.h:150:            std::swap(forward, backward);

and a place where i am confused:

BasicRoutingInterface.h:147:
unpackedPath.push_back(_PathData(ed.id,
_queryData.nodeHelpDesk->getNameIndexFromEdgeID(ed.id),
_queryData.nodeHelpDesk->getTurnInstructionFromEdgeID(ed.id),
ed.distance, _queryData.nodeHelpDesk->getModeFromEdgeID(ed.id)) );

does it matter whether the code above matched the edge in forward or
backward direction? maybe one condition is always false? it is always
used in forward direction? - but maybe I do have some misconception
here.

> On a sidenote, I think the way.direction flag could be removed from
> LUA. Instead you could just set forward and backward speed.

do you also think removing it completely would be a good idea?

jens



More information about the OSRM-talk mailing list