[OSRM-talk] Compiler warnings policy
hofmann at mapbox.com
Mon Sep 11 11:47:47 UTC 2017
If you're familiar with VS2017 and development on Windows, feel free to
enable all warnings but then disable warnings that are not critical (think:
I think our AppVeyor build is also quite spammy in that regard. The main
problem is the core devs don't run Windows :)
On Mon, Sep 11, 2017 at 1:25 PM, Mateusz Loskot <mateusz at loskot.net> wrote:
> On 11 September 2017 at 12:34, Daniel Hofmann <hofmann at mapbox.com> wrote:
> > This Wiki page is a bit outdated; for example there are a few compiler
> > warnings on old compilers in combination with specific boost versions.
> AFAICT, compiling with VS 2017 for 64-bit target gives me ~3.5K warnings,
> though from narrow set of issues:
> > That said we should check warnings for Travis (and the Windows CI ..) and
> > especially our production builds.
> Unless there is -Werror policy, warnings are (almost) never checked :-)
> > I think a "coding standard" boils down to:
> > - adapt your naming convention to what's already present in the code base
> > - use clang-format for formatting
> > - include what you use
> Sounds good.
> Anyway, I asked out of curiosity (seeing largish number of warnings w/
> Best regards,
> Mateusz Loskot, http://mateusz.loskot.net
> OSRM-talk mailing list
> OSRM-talk at openstreetmap.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OSRM-talk