[Potlatch-dev] How about another build?

[Steve Bennett]

On Thu, Dec 23, 2010 at 1:58 AM, Andy Allan <gravitystorm at gmail.com> wrote:
> It's great to see so many bugfixes coming in. But Steve, can you avoid
> hiding bug fixes in amongst other things, please? You're even
> referring to the issue in your commit messages, c.f.
>
> "In amongst all that there are two lines of code that fix the bug: "
> "Fixed a bug [...] also, a bunch of random doco"
>
> It's really hard to figure out what changes are being made - and to
> review them, too - when they keep getting buried like this. Just do
> more of what you're doing, but split into multiple commits so the
> bugfixes are nice and easy to see!

Sure. As I may have mentioned, this is my first time doing this kind
of collaborative development, so I'm still working out the customs,
etiquette, etc.

So, how do most people achieve the above? Make lots of changes, then
deconstruct them into cohesive packages for individual commits? Or,
make small changes and frequently check them in? Or try and work in a
more structured way - just fix the bug now (and check that in), then
write some doco (and check that in...)

In this case I find commenting and bug fixing go hand in hand: as you
understand what the code does, you comment it, which leads you to make
some attempted bug fix...which leads you to write more comments...

Anyway, I'll try and make each commit exactly one of: bug fix, added
feature, doco.

Steve