[openstreetmap-website] Redaction (#39)
Matt Amos
reply+i-3946466-b6e053aa0504a57d9ad201c848003cfaea74d345-1419053 at reply.github.com
Tue Apr 3 15:59:34 BST 2012
These patches add support for "redactions" to the API, which allow the hiding of historical versions of an object and will be used during the license change process and potentially in any later DWG actions.
The redactions API consists of a set of new API calls for nodes, ways and relations to hide historical versions. Redactions themselves are a new resource, with creation and management via the web interface. The web interface & API have also been modified to hide redacted versions via the browse pages, changeset downloads, and other avenues of displaying historical information.
You can merge this Pull Request by running:
git pull https://github.com/zerebubuth/openstreetmap-website redaction
Or you can view, comment on it, or merge it online at:
https://github.com/openstreetmap/openstreetmap-website/pull/39
-- Commit Summary --
* Added Emacs temporaries to gitignore.
* Adding first cut of Redactions support.
* Added scoping for unredacted items, cleaned up auth and Railsified old_node_controller.
* - Add the show_redactions=true parameter to the old_node_controller
* copy the redaction code from nodes to ways
* Altered old_way stuff to be Railsy like old_node is now.
* Added relation redaction logic, same as node and way logic, plus tests.
* Added tests for old_* redaction routes.
* Added test for changeset/download hiding redacted elements and fixed code to pass.
* Added tests for browsing node, way and relation histories with redacted elements and fixed code.
* Fixed AMF controller methods to hide redacted nodes.
* Fixed AMF controller methods to hide redacted ways.
* Added redactions resource.
* Fixed typo in translation.
* Added FK from redactions table to users table.
* Fixed redaction link in redactions list.
* Fixed redaction link in browse/history page.
* Altered styling of redacted versions in changeset list so that they appear deleted and don't leak tag information.
-- File Changes --
M .gitignore (1)
M app/controllers/amf_controller.rb (12)
M app/controllers/application_controller.rb (26)
M app/controllers/changeset_controller.rb (9)
M app/controllers/old_node_controller.rb (57)
M app/controllers/old_relation_controller.rb (55)
M app/controllers/old_way_controller.rb (54)
A app/controllers/redactions_controller.rb (84)
M app/controllers/user_blocks_controller.rb (14)
M app/helpers/browse_helper.rb (15)
M app/models/node.rb (1)
M app/models/old_node.rb (37)
M app/models/old_relation.rb (12)
M app/models/old_way.rb (46)
A app/models/redaction.rb (20)
M app/models/relation.rb (3)
M app/models/way.rb (1)
M app/views/browse/_node_details.html.erb (4)
M app/views/browse/_relation_details.html.erb (4)
M app/views/browse/_way_details.html.erb (4)
A app/views/redactions/_redaction.html.erb (1)
A app/views/redactions/_redactions.html.erb (3)
A app/views/redactions/edit.html.erb (19)
A app/views/redactions/index.html.erb (8)
A app/views/redactions/new.html.erb (20)
A app/views/redactions/show.html.erb (16)
M config/locales/en.yml (41)
M config/routes.rb (6)
A db/migrate/20120318201948_create_redactions.rb (32)
A lib/not_redactable.rb (11)
M lib/osm.rb (13)
A lib/redactable.rb (22)
M test/fixtures/current_nodes.yml (10)
M test/fixtures/current_relations.yml (14)
M test/fixtures/current_ways.yml (7)
M test/fixtures/nodes.yml (20)
A test/fixtures/redactions.yml (6)
M test/fixtures/relations.yml (58)
M test/fixtures/way_nodes.yml (58)
M test/fixtures/way_tags.yml (24)
M test/fixtures/ways.yml (32)
M test/functional/browse_controller_test.rb (45)
M test/functional/changeset_controller_test.rb (16)
M test/functional/old_node_controller_test.rb (124)
M test/functional/old_relation_controller_test.rb (166)
M test/functional/old_way_controller_test.rb (123)
M test/test_helper.rb (2)
M test/unit/node_test.rb (2)
M test/unit/old_node_test.rb (2)
M test/unit/old_way_tag_test.rb (2)
A test/unit/redaction_test.rb (36)
M test/unit/relation_test.rb (2)
M test/unit/way_test.rb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/39.patch
https://github.com/openstreetmap/openstreetmap-website/pull/39.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/39
More information about the rails-dev
mailing list