[openstreetmap-website] Clean rebase (#13)
Andy Allan
gravitystorm at gmail.com
Sat Feb 11 13:56:40 GMT 2012
On 11 February 2012 00:43, Tom Hughes <tom at compton.nu> wrote:
> On 10/02/12 16:57, Tom MacWright wrote:
>
>> Rebased& cleaned commits from the other pull; this unifies the RTL and
>> LTR work, and fixes semicolon style, though a few examples of the random K&R
>> style exist throughout the styles.
>
>
> These changes are up at http://tomh.apis.dev.openstreetmap.org/ if people
> want to take a look and say what they think before I merge anything.
It's great to see some work going into this! Thanks tcmw and tomh for
the work so far.
My main concern is in the top left corner of the map. With the
whitespace removed, we have the map tiles right up against the 1px
grey border, which is part of the tabs effect. Depending on where in
the world you are, it can look a bit nasty since the ocean colour on
the main map and grey outline clash - add in a disabled tab (e.g. zoom
out until the edit tab is disabled) and there are three
hard-to-distinguish colours. I think we need something there to
separate the tabs and the map. The active tab especially needs some
whitespace to "join" the tab to the contents.
Also, the sidebars (e.g. search, data) could do with some similar
removal of linework. I notice that there's now a 2px-ish gap between
the sidebar and the map - that's probably not intended.
Cheers,
Andy
P.S. I still like all the rounded corners that I put in, even if they
are now soooo 2011 :-)
More information about the rails-dev
mailing list