[openstreetmap-website] Don't show coordinates for deleted nodes. (#51)

Andy Allan reply+i-5497507-ae596aecd523018ef685cafaf1d2e00ba7276f70-1419053 at reply.github.com
Mon Jul 9 13:30:02 BST 2012


We shouldn't show the coordinates of deleted nodes, since we don't show the 'geometries' of deleted ways or relations, nor the tags of any deleted object. 

Additionally, the coordinates of a deleted version are actually the coordinates of the previous visible version, so in themselves contain no useful information. However, they instead provide a mechanism for viewing redacted information.

In future the lat/lon attributes of deleted nodes could be removed, but for now simply set them as "0"/"0" for clients who expect them to be there.

See http://lists.openstreetmap.org/pipermail/rebuild/2012-July/000308.html for more context.

You can merge this Pull Request by running:

  git pull https://github.com/gravitystorm/openstreetmap-website deleted-nodes

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/51

-- Commit Summary --

* Don't show coordinates for deleted nodes.

-- File Changes --

M app/models/node.rb (6)
M app/models/old_node.rb (6)
M app/views/browse/_node_details.html.erb (2)
M app/views/browse/node.html.erb (13)
M app/views/browse/node_history.html.erb (4)
M config/locales/en.yml (1)

-- Patch Links --

  https://github.com/openstreetmap/openstreetmap-website/pull/51.patch
  https://github.com/openstreetmap/openstreetmap-website/pull/51.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/51



More information about the rails-dev mailing list