[openstreetmap-website] Port to Leaflet (#121)
John Firebaugh
notifications at github.com
Mon Nov 5 16:29:44 GMT 2012
> * Activating the "manually select an area" option in the export tab is very visually jarring because it triggers a zoom out in order to be able to highlight the whole of the current view as the selected area. I suspect it would be better to start with a smaller area selected that didn't trigger the zoom out.
I agree. I think this should be an optional behavior of LocationFilter, so I'll work on an upstream patch.
> * The user settings page doesn't show the location marker on the map - probably related to the Couldn't autodetect L.Icon.Default.imagePath, set it manually error that I see in the javascript console.
Fixed. Missed this one because it only appears in production.
> * Layout of popups on the map on the user page has changed - is this deliberate?
Nope, looks like an explicit width needs to be applied somewhere. I'll look into it.
> * The bbox parameter has vanished from the "view area on larger map" links on the data browser pages for ways etc, which means the box doesn't appear on the map when you follow it.
Fixed.
> * The node view in the data browser reports e is undefined and the map never appears.
I can't reproduce this; can you be more specific?
Also I've noticed that the map doesn't print correctly. Not sure if this is a Leaflet or OSM issue yet.
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/121#issuecomment-10077069
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20121105/0dfeaf6b/attachment.html>
More information about the rails-dev
mailing list