[openstreetmap-website] non-functional visibility check in `Relation#to_xml_node` (#139)

[Tom Hughes]

Well what it's trying to do is to make sure that any purported member of a relation which has actually been deleted is not returned - the `visible_members` thing is a way of optimising that check in some cases but the check itself is being attempted in all cases.

Of course we shouldn't ever see this because you shouldn't be able to delete something that is still a member of a relation but historically the API has tried to hide any such broken data if it does somehow occur.

So the question now is whether to assume that broken data won't occur and get rid of the check, or fix the check...

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/139#issuecomment-10697054
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20121125/3c7df819/attachment.html>