[openstreetmap-website] non-functional visibility check in `Relation#to_xml_node` (#139)

John Firebaugh notifications at github.com
Mon Oct 22 01:57:01 GMT 2012

What's going on [here](https://github.com/openstreetmap/openstreetmap-website/blob/e64bcf335a95f7cc35cd19c190b8111c2d7b275f/app/models/relation.rb#L150)? `p` is either 0 or 1, both of which are truthy in Ruby, so the `if` block is always executed.

Do we need this check?

Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20121021/48430e04/attachment-0001.html>

More information about the rails-dev mailing list