[openstreetmap-website] Use a param to trigger export rather than a separate action (#86)

John Firebaugh notifications at github.com
Fri Sep 7 00:24:14 BST 2012


In `site/_resize.html.erb` and `site/_search.html.erb`, a
`params[:action]` conditional is used to include code that should only run on
the index action -- but it should be run on the export action too. Cleanest
fix is to eliminate that action entirely.

You can merge this Pull Request by running:

  git pull https://github.com/jfirebaugh/openstreetmap-website export_param

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/86

-- Commit Summary --

  * Use a param to trigger export rather than a separate action

-- File Changes --

M app/controllers/site_controller.rb (4)
M app/views/layouts/site.html.erb (2)
M app/views/site/index.html.erb (2)
M config/routes.rb (1)
M test/functional/site_controller_test.rb (16)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/86.patch
https://github.com/openstreetmap/openstreetmap-website/pull/86.diff


---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/86
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20120906/383db036/attachment.html>


More information about the rails-dev mailing list