[openstreetmap-website] Move param-based map configuration to client (#94)

John Firebaugh notifications at github.com
Thu Sep 13 04:08:29 BST 2012


This prepares us for hash-based permalinks (#81) and removes the
duplication between index.html.erb and SiteController#edit.

I've started a discussion on the mailing list regarding JS testing
technologies such as Konacha.

You can merge this Pull Request by running:

  git pull https://github.com/jfirebaugh/openstreetmap-website permalinks

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/94

-- Commit Summary --

  * Extract layer configuration to map.js
  * Move param-based map configuration to client
  * Konacha tests for OSM.mapParams

-- File Changes --

M Gemfile (4)
M Gemfile.lock (33)
M app/assets/javascripts/application.js (1)
M app/assets/javascripts/globals.js.erb (3)
M app/assets/javascripts/map.js.erb (8)
A app/assets/javascripts/params.js (100)
M app/controllers/site_controller.rb (48)
M app/views/layouts/_head.html.erb (8)
M app/views/site/_potlatch.html.erb (3)
M app/views/site/_potlatch2.html.erb (6)
M app/views/site/index.html.erb (145)
A config/initializers/konacha.rb (3)
A test/javascripts/params_test.js (120)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/94.patch
https://github.com/openstreetmap/openstreetmap-website/pull/94.diff


---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/94
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20120912/60b4640e/attachment.html>


More information about the rails-dev mailing list