[openstreetmap-website] Clean up index JS (#108)

John Firebaugh notifications at github.com
Sat Sep 29 17:02:21 BST 2012


Eliminate interpolation, move to page-specific script file, and
wrap in a single $(document).ready().

This includes the change from #107 as well.

You can merge this Pull Request by running:

  git pull https://github.com/jfirebaugh/openstreetmap-website index_js

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/108

-- Commit Summary --

  * Use the jQuery data() function to access HTML 5 data attributes
  * Eliminate interpolation in index JS
  * Move index JS to page-specific script file
  * Wrap in a single $(document).ready()

-- File Changes --

A app/assets/javascripts/index.js (129)
M app/views/layouts/_head.html.erb (2)
M app/views/layouts/site.html.erb (5)
M app/views/site/_potlatch.html.erb (7)
M app/views/site/_potlatch2.html.erb (7)
M app/views/site/index.html.erb (158)
M config/application.rb (3)
M config/i18n-js.yml (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/108.patch
https://github.com/openstreetmap/openstreetmap-website/pull/108.diff


---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/108
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20120929/7b0aa3ab/attachment.html>


More information about the rails-dev mailing list