[openstreetmap-website] Update to rails 4 (#432)

[Tom Hughes]

This pull request updates the site to use rails 4. All tests pass, and all deprecation warnings reported by the tests are fixed, but it does currently rely on patched versions of two gems (oauth-plugin and i18n-js).

There is a test site at http://rails4.apis.dev.openstreetmap.org/ and this could do with some testing before we think about merging it.
You can merge this Pull Request by running:

  git pull https://github.com/tomhughes/openstreetmap-website rails4

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/432

-- Commit Summary --

  * Update to rails 4.0.0
  * Remove multiline regular expression anchors from validations
  * Replace attr_accessible with strong parameters
  * Eliminate deprecated scope and association arguments
  * Monkey patch PostgreSQLAdapter to make enums work
  * Replace deprecated `scoped` method with `all`
  * Rails now defaults to using PATCH for updates
  * IntegrationTest is now in ActionDispatch not ActionController
  * Replace deprecated finder methods
  * RoutingError is now UrlGenerationError
  * Remove format specifier from RSS feed route tests
  * Remove deprecated assert_blank and assert_present from tests
  * Detect test environment correctly
  * Set hostname for signed requests correctly
  * Always allow %{attribute} in model validation error messages
  * Fix rails 4 compatibility issues in migrations
  * Avoid singleton serialisation errors

-- File Changes --

    M Gemfile (48)
    M Gemfile.lock (187)
    M app/assets/javascripts/leaflet.extend.js.erb (2)
    M app/controllers/api_controller.rb (4)
    M app/controllers/browse_controller.rb (4)
    M app/controllers/changeset_controller.rb (4)
    M app/controllers/diary_entry_controller.rb (22)
    M app/controllers/message_controller.rb (8)
    M app/controllers/notes_controller.rb (10)
    M app/controllers/oauth_clients_controller.rb (8)
    M app/controllers/trace_controller.rb (6)
    M app/controllers/user_blocks_controller.rb (8)
    M app/controllers/user_controller.rb (15)
    M app/controllers/user_roles_controller.rb (4)
    M app/models/access_token.rb (2)
    M app/models/client_application.rb (10)
    M app/models/diary_comment.rb (2)
    M app/models/diary_entry.rb (18)
    M app/models/message.rb (6)
    M app/models/node.rb (6)
    M app/models/note.rb (7)
    M app/models/oauth_nonce.rb (2)
    M app/models/oauth_token.rb (6)
    M app/models/old_relation.rb (2)
    M app/models/relation.rb (14)
    M app/models/request_token.rb (2)
    M app/models/trace.rb (8)
    M app/models/tracetag.rb (4)
    M app/models/user.rb (34)
    M app/models/user_block.rb (4)
    M app/models/user_preference.rb (2)
    M app/models/user_token.rb (2)
    M app/models/way.rb (10)
    M config/application.rb (30)
    M config/environments/development.rb (34)
    M config/environments/production.rb (70)
    M config/environments/test.rb (27)
    D config/initializers/buffered_logger.rb (14)
    A config/initializers/filter_parameter_logging.rb (4)
    M config/initializers/inflections.rb (11)
    M config/initializers/paperclip.rb (3)
    M config/initializers/postgresql_adapter.rb (13)
    A config/initializers/secret_token.rb (12)
    M config/initializers/wrap_parameters.rb (12)
    M config/preinitializer.rb (7)
    M config/routes.rb (20)
    M db/migrate/001_create_osm_db.rb (4)
    M db/migrate/031_create_countries.rb (4)
    M db/migrate/053_add_map_bug_tables.rb (4)
    M db/migrate/054_refactor_map_bug_tables.rb (4)
    M lib/classic_pagination/pagination.rb (31)
    M lib/geo_record.rb (2)
    M lib/redactable.rb (2)
    M test/functional/amf_controller_test.rb (4)
    M test/functional/browse_controller_test.rb (4)
    M test/functional/changeset_controller_test.rb (16)
    M test/functional/diary_entry_controller_test.rb (10)
    M test/functional/message_controller_test.rb (8)
    M test/functional/old_node_controller_test.rb (2)
    M test/functional/trace_controller_test.rb (2)
    M test/functional/user_blocks_controller_test.rb (12)
    M test/functional/user_controller_test.rb (20)
    M test/functional/way_controller_test.rb (2)
    M test/integration/client_application_test.rb (2)
    M test/integration/cors_test.rb (2)
    M test/integration/oauth_test.rb (6)
    M test/integration/short_links_test.rb (2)
    M test/integration/user_blocks_test.rb (10)
    M test/integration/user_creation_test.rb (2)
    M test/integration/user_diaries_test.rb (2)
    M test/integration/user_login_test.rb (2)
    M test/integration/user_roles_test.rb (2)
    M test/integration/user_terms_seen_test.rb (2)
    M test/unit/diary_entry_test.rb (4)
    M test/unit/i18n_test.rb (4)
    M test/unit/node_test.rb (4)
    M test/unit/oauth_token_test.rb (4)
    M test/unit/trace_test.rb (4)
    M test/unit/tracetag_test.rb (4)
    M test/unit/user_test.rb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/432.patch
https://github.com/openstreetmap/openstreetmap-website/pull/432.diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130807/7b881f08/attachment.html>