[openstreetmap-website] Notes (aka OpenStreetBugs) (#209)

Tom Hughes notifications at github.com
Sun Feb 3 10:45:26 GMT 2013 

I think I have now resolved the outstanding issues with the notes branch.

As agreed previously at EWG it now shows a warning when viewing a note with anonymous comments that such information should be independently verified.

It's running at http://notes.apis.dev.openstreetmap.org/ so please try it out as much as possible and report any problems before it gets merged. You can comment here, or open issues against my repo at https://github.com/tomhughes/openstreetmap-website/issues.
You can merge this Pull Request by running:

  git pull https://github.com/tomhughes/openstreetmap-website notes

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/209

-- Commit Summary --

  * Create a branch to play around with some ideas for integrating OpenStreetBugs into the rails_port
  * An initial (incomplete) "proof of concept" integration of an OpenStreetBugs interface into the rails port
  * Split comment field out of map bugs table
  * Allow for different formats to the getBugs call
  * Fixed small bug where clicking on the "Report a Problem" link would directly create a bug-report
  * support json format in getBugs, add a limit and name parameter
  * Change comment type from varchar(255) to text
  * Escape javascript in output
  * Record time of closure of a bug.
  * Add a browse page for bugs
  * try and make the OpenStreetBugs API a bit more consistent with the rest of the API
  * back out the registration of the gpx mime type, as it didn't seem work
  * Fixup some of the rss output and geocode bugs using nominatim
  * List bugs submited or commented on by user
  * Fixup some error handling in map bugs
  * Add some rudimentary initial tests for the map bugs api
  * Merge -r 20198:20540 from trunc into openstreetbugs branch
  * Don't limit get map_bugs to a small Area, by disabling the quadtile index for those searches
  * Convert openstreetbugs javascript to new style api
  * minor improvement to the map_bugs tests
  * Reuse the map_bug_comment table as a more general history table of map_bugs including close and reopen events
  * Fixed some minor bugs and add tests to spot them
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' of git://git.openstreetmap.org/rails into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs2
  * Minor fix to updated OpenLayers
  * users.visible has changed to users.status
  * Merge branch 'master' into openstreetbugs
  * Merge remote-tracking branch 'apmon/openstreetbugs2' into openstreetbugs
  * Use local files rather than remote ones for osb images
  * Change bug comment to a textarea to make it easier to input longer comments
  * Grey out username text field for bugs when logged in.
  * Link the openstreetbugs browse pages
  * Remove references to old server location
  * Forgott to copy over an image from openstreetbugs.schokokeks.org
  * Deactivate OSB controller immediately after clicking a new bug
  * Update OSB internationalisation to match the rails_port way
  * Add a note that the OSB client side js library has been adapted from the original
  * Send notification emails when someone comments on a map bug report
  * Merge branch 'master' into openstreetbugs
  * Merge remote-tracking branch 'apmon/openstreetbugs2' into openstreetbugs
  * Only show "Report a problem" link at zoom level 12 and higher
  * Make the bug popups look a little nicer
  * Increase font-size of the "report a problem" link
  * Don't enable OSB layer by default
  * Merge branch 'openstreetbugs' of git://git.openstreetmap.org/rails into openstreetbugs2
  * Merge branch 'master' of git://git.openstreetmap.org/rails into openstreetbugs2
  * Don't require a second click to create an OpenStreetBug
  * Merge branch 'master' into openstreetbugs
  * Tidy up some of the map bugs code
  * Switch back to using the local OL build as it seems to work fine
  * Detabify and tidy up some more of the bugs code
  * Factor out common code into partials
  * Get returning of bugs as GPX files working
  * Merge the gpx_bugs action into the main get_bugs action
  * Detabify and tidy up some more of the bugs code
  * Always get the bug commenter name from the user if there is one
  * Place legacy routes after their replacements
  * Rename association between map_bugs and map_bug_comment to comments
  * Don't add a geographic condition when fetching an RSS feed with no bbox
  * Add a C implementation of QuadTile.iterate_tiles_for_area
  * Use quad tiling to select bugs in an area
  * Make the edit action default to z17
  * Add the .DS_Store file to the gitignore (often added by default).
  * Update the rss feed logo, to use the new logo.
  * Make sure the ruby quadtile code give the same result as the C version
  * Rename some columns and indexes in the bug tables
  * Allow any valid (per RFC 3986) scheme name in OAuth callback URLs
  * Add methods to get a bug's author details from the first comment
  * Use the right author name for bugs in RSS format
  * User an RJS template for the javascript response
  * Fix a few minor issues in the print stylesheet
  * Simplify URL scheme name matching in OAuth callback URLs a little
  * Don't allow libxml 2.0.0 and later to be used
  * Make "all traces" and "your traces" links more consistent
  * Handle large bounding box changesets better
  * Rename a number of methods in the map_bugs controller
  * Merge branch 'master' into openstreetbugs
  * Mass rename of "bugs" as "notes" for increased user friendliness
  * Tidy up the note model a bit
  * Tidy up the note_comment model a bit
  * Update tests for change in name from "map_bug" to "note" etc
  * Tidy up the note controller
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Merge branch 'master' into openstreetbugs
  * Use correct URL for note details
  * Get the note browse pages into a vaguely working state
  * Add next/previous tooltips for browsing notes
  * Enable the note later when going from the browser to the map view
  * First pass at banishing the words "bug" and "OpenStreetBugs"
  * Tidy up some insanity in the creating of new notes
  * Move the marker with the mouse when positioning a note
  * More cleanup work on the notes javascript
  * Remove the notes control
  * Turn on the note layer when adding a note
  * Merge branch 'master' into openstreetbugs
  * Allow the format to be selected for note API responses
  * Improve formatting of note descriptions in GPX and RSS responses
  * Merge branch 'master' into openstreetbugs
  * Return GeoJSON for notes when JSON format is requested
  * Rework notes interface using OpenLayers and rails
  * Merge branch 'master' into openstreetbugs
  * MapBoundary no longer exists
  * Bounding boxes are sanitised on creation now
  * Use jsonify to create JSON for notes so that it is properly formatted
  * Move notes resources to assets directory
  * Deselect note features when the popup is closed
  * Merge branch 'master' into openstreetbugs
  * Drop with_format and user the new :formats render option instead
  * Include the event type in the JSON output of a note
  * Make setting of a default status for new notes work
  * User errors.add(:base) instead of the removed errors.add_to_base()
  * Fix mass assignment issues
  * Update schema
  * Remove redundant routes and add default format specifiers
  * Update note controller tests for new GeoJSON output
  * Fix some bugs found by the note controller tests
  * Get the per-user note list view working again
  * Merge branch 'master' into openstreetbugs
  * Restructure notes URLs according to standard rails conventions
  * Start rewriting the notes layer for the front page
  * Merge branch 'master' into openstreetbugs
  * Add OpenLayers.Format.QueryStringFilter to the OpenLayers build
  * Add an entry to the edit menu for turning on the notes layer
  * Merge branch 'master' into openstreetbugs
  * Use standard indentation
  * Add support for creating new notes
  * Remove redundant code
  * Generate proper descriptions for notes
  * Fix require paths in migrations
  * Drop renaming of sequences
  * Update database schema
  * Merge branch 'master' into notes
  * Refactor notes code to work with recent site changes
  * Use EJS templates for notes
  * Localise notes interface
  * Use named routes in note RSS builder
  * Include useful URLs in note responses
  * Get note comment notification working again
  * Return a copy of the note data on creation and update
  * Allow an optional comment to be given when closing a note
  * Allow commenting on, and closing of, notes from the web site
  * Refactor note add/update code
  * Set attributes on newly created notes
  * Improve styling of notes popups
  * Remove unused translations
  * Remove unused stylesheet rules
  * Fix up issues with notes in the data browser
  * Correct field name
  * Fix links to user notes
  * Return the body of a note comment as a rich text object
  * Replace htmlize call by rich text to_html call
  * Merge branch 'master' into notes
  * Update list of filtered methods in notes controller
  * Disable buttons while form submission is in progress
  * Recover properly from a failed notes load
  * Merge branch 'master' into notes
  * Fix formatting of comments in the notes RSS feed
  * Get the notes tests working again
  * Remove nearby_place from the note model
  * Move caching of reverse geocodes to describe_location
  * Merge branch 'master' into notes
  * Rework notes UI using leaflet
  * Add a scrollbar when a note gets too big
  * Make sure popups don't overlay controls or the top bar
  * Police the MAX_NOTE_REQUEST_AREA limit on the client
  * Abort any existing load before starting a new one
  * Remove the author_name field from notes
  * Include a user URL in JSON and XML responses
  * Link user names to their pages
  * Format note comments correctly in the data browser
  * Return note comments as formatted HTML as well as text
  * Display formatted notes in the web UI
  * Convert author_ip to a proper INET field
  * Style disabled permalinks appropriately
  * Don't try and add a note when the control is disabled
  * Merge branch 'master' into notes
  * Set width of comment entry area in note popups
  * Fix notes page in data browser to match new site style
  * Merge branch 'master' into notes
  * Improve comment descriptions in note popups
  * Localise dates and times in notes popups
  * Tweak sizing of note popups
  * Improve display of anonymous note comments
  * Improve styling of the per-user notes list view
  * Add anonymous comment warning to note popup
  * Show anonymous user warning in data browser note view
  * Make notes RSS feeds work

-- File Changes --

    M Gemfile (1)
    M Gemfile.lock (17)
    A app/assets/images/closed_note_marker.png (0)
    A app/assets/images/new_note_marker.png (0)
    A app/assets/images/open_note_marker.png (0)
    M app/assets/javascripts/browse.js (19)
    M app/assets/javascripts/index.js (1)
    A app/assets/javascripts/index/notes.js.erb (209)
    M app/assets/javascripts/osm.js.erb (15)
    A app/assets/javascripts/templates/notes/new.jst.ejs (12)
    A app/assets/javascripts/templates/notes/show.jst.ejs (33)
    M app/assets/stylesheets/common.css.scss (70)
    M app/controllers/browse_controller.rb (9)
    A app/controllers/notes_controller.rb (318)
    M app/helpers/application_helper.rb (4)
    M app/helpers/geocoder_helper.rb (18)
    A app/helpers/note_helper.rb (17)
    A app/models/note.rb (71)
    A app/models/note_comment.rb (17)
    M app/models/notifier.rb (28)
    M app/models/user.rb (2)
    M app/views/browse/_map.html.erb (25)
    A app/views/browse/note.html.erb (67)
    M app/views/diary_entry/_location.html.erb (2)
    A app/views/notes/_description.html.erb (12)
    A app/views/notes/_note.gpx.builder (18)
    A app/views/notes/_note.json.jsonify (33)
    A app/views/notes/_note.rss.builder (24)
    A app/views/notes/_note.xml.builder (31)
    A app/views/notes/_notes_paging_nav.html.erb (17)
    A app/views/notes/_user.html.erb (1)
    A app/views/notes/feed.rss.builder (52)
    A app/views/notes/index.gpx.builder (7)
    A app/views/notes/index.json.jsonify (5)
    A app/views/notes/index.rss.builder (13)
    A app/views/notes/index.xml.builder (3)
    A app/views/notes/mine.html.erb (35)
    A app/views/notes/show.gpx.builder (7)
    A app/views/notes/show.json.jsonify (1)
    A app/views/notes/show.rss.builder (13)
    A app/views/notes/show.xml.builder (3)
    A app/views/notifier/note_comment_notification.html.erb (13)
    A app/views/notifier/note_comment_notification.text.erb (13)
    M app/views/site/index.html.erb (6)
    M app/views/user/view.html.erb (6)
    M config/example.application.yml (2)
    M config/i18n-js.yml (2)
    A config/initializers/action_view.rb (32)
    M config/initializers/mime_types.rb (1)
    M config/locales/de.yml (16)
    M config/locales/en.yml (71)
    M config/openlayers.cfg (5)
    M config/routes.rb (24)
    A db/migrate/053_add_map_bug_tables.rb (33)
    A db/migrate/054_refactor_map_bug_tables.rb (34)
    A db/migrate/055_change_map_bug_comment_type.rb (11)
    A db/migrate/056_add_date_closed.rb (11)
    A db/migrate/057_add_map_bug_comment_event.rb (15)
    A db/migrate/20110508145337_cleanup_bug_tables.rb (25)
    A db/migrate/20110521142405_rename_bugs_to_notes.rb (51)
    A db/migrate/20121119165817_drop_nearby_place_from_notes.rb (9)
    A db/migrate/20121202155309_remove_author_name_from_note_comment.rb (9)
    A db/migrate/20121203124841_change_note_address_to_inet.rb (9)
    M db/structure.sql (216)
    M lib/bounding_box.rb (13)
    M lib/geo_record.rb (1)
    M lib/migrate.rb (19)
    A lib/nominatim.rb (26)
    A test/fixtures/note_comments.yml (107)
    A test/fixtures/notes.yml (67)
    M test/functional/browse_controller_test.rb (4)
    A test/functional/notes_controller_test.rb (464)
    M vendor/assets/openlayers/OpenLayers.js (187)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/209.patch
https://github.com/openstreetmap/openstreetmap-website/pull/209.diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130203/e772cd69/attachment-0001.html>

More information about the rails-dev mailing list