[openstreetmap-website] fixes for trac #4730 (also #4748) (#216)

Eric Theise notifications at github.com
Tue Feb 26 21:27:33 UTC 2013


Modifications to 

app/controllers/geocoder_controller.rb
app/helpers/geocoder_helper.rb
test/functional/geocoder_controller_test.rb

to "Support more syntax for lon/lat coordinates". Added tests, then added code and tests to get at the requests that are more clearly spelled out in #4748 than #4730. Went beyond the request so that latlon can be cut-and-paste from Wikipedia entries (and for that I added primes and double primes to the regexps).

Have not added support for UTM requested at the bottom of #4748.
You can merge this Pull Request by running:

  git pull https://github.com/erictheise/openstreetmap-website 4730

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/216

-- Commit Summary --

  * Fixing two typos
  * Fixing typo and outdated information.
  * Adding simple yml file for Travis Continuous Integration
  * First draft of Travis CI YAML file
  * Merge remote-tracking branch 'upstream/master'
  * Adding steps to before_script
  * Create user correctly
  * Create user correctly, continued
  * Create user correctly, continued
  * Create user correctly, continued
  * Create user correctly, continued
  * Run the db migration
  * Seems to work; adding rubies and status badge
  * Trying to install the quadtile functions
  * Trying to install the quadtile functions, continued
  * Trying to install the quadtile functions, continued
  * merging upstream changes
  * Re-enabling builds for 1.8.7 & 1.9.2
  * Merge remote-tracking branch 'upstream/master'
  * Merge remote-tracking branch 'upstream/master'
  * Merge remote-tracking branch 'upstream/master'
  * Merge remote-tracking branch 'upstream/master'
  * Merge remote-tracking branch 'upstream/master'
  * Merge branch 'master' of github.com:erictheise/openstreetmap-website
  * adding tests for existing behavior of geocoder search
  * tests and controller work to identify two general cases of degree/minute/second latlons; no calcs
  * use * instead of ? for whitespace tests
  * day's work; still need to test +/- NSEW
  * found some bugs, more tests, moved tests to before_filter, verified conversions
  * should be able to cut and paste out of wikipedia; adding single prime alongside apostrophe, testing
  * adding double prime alongside quotation

-- File Changes --

    A .travis.yml (16)
    M README.md (2)
    M app/controllers/geocoder_controller.rb (18)
    M app/helpers/geocoder_helper.rb (25)
    M config/example.database.yml (4)
    M test/functional/geocoder_controller_test.rb (198)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/216.patch
https://github.com/openstreetmap/openstreetmap-website/pull/216.diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130226/d4279537/attachment.html>


More information about the rails-dev mailing list