[openstreetmap-website] Site cleanup (#150)

Tom Hughes notifications at github.com
Tue Jan 8 22:53:18 GMT 2013


I've been going through it all this evening and it looks like you fixed up almost everything I mentioned the other day successfully.

Unfortunately the new heading system breaks on the pages which had caching enabled because the heading doesn't get set when cached content is returned - that's the real reason why the heading was missing on the diary list view in the test instance as that is running in production mode so has caching on. I've disabled that caching for now but I need to think if there is a better solution.

Other than that the only thing that still seems to be a problem as far as I know is the search results. You reordered the components in the result text, putting the prefix text at the end (which is an odd idea of prefix ;-)) but that doesn't really help because it makes assumptions about what the prefix is and different geocoder backends use it in different ways.

The geocoder backends assume that `result_to_html` will assemble the components they provide in a particular order to create a sentence and which the nominatim backend may look OK in a different order, other backends ike the geonames one just look silly:

![Screenshot from 2013-01-08 22:51:57](https://f.cloud.github.com/assets/147741/51966/20d7de6e-59e6-11e2-93eb-4aa2edf45eb3.png)


---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/150#issuecomment-12021981
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130108/472ab1ff/attachment.html>


More information about the rails-dev mailing list