[openstreetmap-website] Search sidebar: don't scroll heading ('close' stays visible) (#363)

danstowell notifications at github.com
Sat Jul 20 13:43:09 UTC 2013


Here's the problem:
(a) On the OSM homepage, search for something that has many results (e.g. "pub")
(b) Scroll down in the list of results.
(c) Now decide you want to close the search results sidebar. Unfortunately, the "Close" link is now scrolled out of reach, and you have to tediously scroll back up just to close the thing.

This patch changes behaviour so it's the content (#sidebar_content) that scrolls, rather than the outer container (#sidebar), meaning that the heading block stays visible.
You can merge this Pull Request by running:

  git pull https://github.com/danstowell/openstreetmap-website scrollheadingfix

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/363

-- Commit Summary --

  * Search sidebar: don't scroll heading ('close' stays visible)

-- File Changes --

    M app/assets/stylesheets/common.css.scss (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/363.patch
https://github.com/openstreetmap/openstreetmap-website/pull/363.diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130720/321614a3/attachment.html>


More information about the rails-dev mailing list