[openstreetmap-website] Diary cleanup (#218)

[Tom Hughes]

> @@ -4,7 +4,16 @@
>        <%= user_thumbnail diary_entry.user %>
>      <% end %>
>  
> -    <h2><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></h2>
> +    <h2>
> +      <% if params[:action] == 'list' %>
> +      <%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %>
> +       <% else %>
> +      <%= diary_entry.title %>
> +      <% end %>
> +    </h2>
> +    <small class='deemphasize'>

What's win here? Do we just think it's "prettier" if the title isn't a link on the diary entry view? It's adding a  very kludgy complication to the template, and removing a handy link that can be used to grab a link to the diary entry so I'd like there to be a decent upside to make it a worthwhile change.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/218/files#r3504482
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130324/3e519352/attachment.html>