[openstreetmap-website] Add view pages for specific versions (#720)
danstowell
notifications at github.com
Tue Apr 1 20:37:06 UTC 2014
Hi - there's a bug in the edited version of `_common_details.html.erb` line 20 - if I go to `/way/11032776` I get a NoMethodError for `way_id`. If I change `way_id` to `id` then `/way/11032776` works again... but it breaks `/way/11032776/history/4`! I don't think this Pull Request is safe yet...
Also note that `_common_details.html.erb` is supposed to be common to all object types: nodes, ways, relations. Therefore you can't directly just refer to `:way_version` or `way_id` as you currently do - because it creates further problems: when I go to `/node/98316992` your patch adds an extra link, but the link is to `/way/98316992/history/6` which is wrong (should say `node` not `way`).
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/720#issuecomment-39255494
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20140401/bdb2ce85/attachment.html>
More information about the rails-dev
mailing list