[openstreetmap-website] Rescue to StandardError instead of Exception (#852)

Tom Hughes notifications at github.com
Mon Dec 8 09:26:19 UTC 2014


Well most of the things mentioned there (like ctrl-C not working) only apply in an interactive context.

It's probably true in this case at least that there's nothing extra that Exception would catch that is very likely to happen, but the basic design here is that this function is a "nice to have" and if anything at all goes wrong we just want to carry on - everything will work fine without a result from it.

I guess the most likely issue is it swallowing a signal, though I'm not sure why we would be receiving one, or what the best behaviour is if we do get one.

The comments on the first answer on SO that say lots of gems create exceptions directly descending from `Exception` are also a little concerning, though we're not using much in that block so it probably isn't a big issue here.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/852#issuecomment-66042437
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20141208/452340d7/attachment.html>


More information about the rails-dev mailing list